Skip to content

feat(auth): Add ExtraQueryParams to AuthSignInWithRedirectInput #13892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(auth): Add ExtraQueryParams to AuthSignInWithRedirectInput #13892

wants to merge 9 commits into from
+36 −0

Conversation

@sarossilli
Copy link

Description of changes

Adding extraQueryParams to AuthSignInWithRedirectInput.

Adding paramters from extraQueryParams to queryString of oAuthUrl

This will allow users to define extra 'custom' query parameters to the /authorize url for custom ODIC auth providers.

Issue #, if available

Feature Request: #13861

Description of how you validated changes

yarn test passes

Built and linked local changes using yarn link

Ran test app with linked local changes.

Validated authorization url now contains new custom-added parameters when calling signInIWithRedirect.

Example usage:

        signInWithRedirect({
            provider: {
                custom: "TwitchOIDC",
            },
            extraQueryParams: {
                claims: 'test'
            }
        })

And /authorize URL query params are:

redirect_uri=[uri]
&response_type=code
&client_id=[id]&identity_provider=TwitchOIDC
&scope=[scope]&state=[state]&code_challenge=[uuid]
&code_challenge_method=S256
&claims=test

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sarossilli sarossilli force-pushed the feat/query-params-authorization-url branch from 33ba1ca to 2767ac3 Compare October 5, 2024 17:23
@cwomack cwomack added external-contributor Auth Related to Auth components/category labels Nov 26, 2024
@dinhtuanan dinhtuanan mentioned this pull request Dec 10, 2024
Closed
2 tasks
@wildjames
Copy link

We've also run into an issue with this on our team, are there any temporary workarounds that can be used while this PR is in review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haverchuck haverchuck Awaiting requested review from haverchuck

@cshfang cshfang Awaiting requested review from cshfang

@jimblanc jimblanc Awaiting requested review from jimblanc

@HuiSF HuiSF Awaiting requested review from HuiSF

@pranavosu pranavosu Awaiting requested review from pranavosu pranavosu is a code owner

@sktimalsina sktimalsina Awaiting requested review from sktimalsina

@sobolk sobolk Awaiting requested review from sobolk

@Amplifiyer Amplifiyer Awaiting requested review from Amplifiyer

@avi-karthik avi-karthik Awaiting requested review from avi-karthik avi-karthik is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Auth Related to Auth components/category external-contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sarossilli @wildjames @cwomack